Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add James Duong to committers #435

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Add James Duong to committers #435

merged 2 commits into from
Nov 28, 2023

Conversation

jduo
Copy link
Member

@jduo jduo commented Nov 22, 2023

@jduo jduo requested a review from thisisnic November 22, 2023 18:04
kou
kou approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Welcome!

kou
kou reviewed Nov 23, 2023
View reviewed changes
_data/committers.yml Outdated Show resolved Hide resolved
@jduo @kou
Update _data/committers.yml
6993bce 
Co-authored-by: Sutou Kouhei <[email protected]>
@kou
Copy link
Member

kou commented Nov 23, 2023

@jduo Do you want to merge this by yourself as a new committer? :-)

@jduo jduo merged commit 12fbced into apache:main Nov 28, 2023
1 check passed
@jduo
Copy link
Member Author

jduo commented Nov 28, 2023

Thanks @kou !

@jduo jduo deleted the add-jduo-to-committers branch November 28, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

@thisisnic thisisnic Awaiting requested review from thisisnic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jduo @kou