Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Build Instructions #450

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

bkmgit
Copy link
Contributor

@bkmgit bkmgit commented Jan 5, 2024

Remove outdated instructions for building GLib. Refer to source repositories instead.

@bkmgit
Copy link
Contributor Author

bkmgit commented Jan 8, 2024

Closes #459

@alamb alamb requested a review from kou February 9, 2024 20:29
@alamb
Copy link
Contributor

alamb commented Feb 9, 2024

Thank you @bkmgit

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated

This is built in the repositories corresponding to each code and then copied into
the website repository before deploying the website. Separate tooling is used for
creating the code documentation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can remove this section.
Some repositories such as apache/arrow and apache/arrow-ballista copy their documents to this repository but others such as apache/arrow-adbc and apache/arrow-datafusion uses their repositories. See also: https://github.com/apache/arrow-adbc/blob/1e1a57623761d564ac4a99a213fbeb4142b4b57a/.asf.yaml#L39-L41

I don't think that we need to describe them here because each repository should have documentation for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the section.

@bkmgit bkmgit requested a review from kou April 22, 2024 03:24
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 379c024 into apache:main Apr 22, 2024
1 check passed
@bkmgit bkmgit deleted the update-build-instructions branch April 22, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants