-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Build Instructions #450
Conversation
Closes #459 |
Thank you @bkmgit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
README.md
Outdated
|
||
This is built in the repositories corresponding to each code and then copied into | ||
the website repository before deploying the website. Separate tooling is used for | ||
creating the code documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we can remove this section.
Some repositories such as apache/arrow
and apache/arrow-ballista
copy their documents to this repository but others such as apache/arrow-adbc
and apache/arrow-datafusion
uses their repositories. See also: https://github.com/apache/arrow-adbc/blob/1e1a57623761d564ac4a99a213fbeb4142b4b57a/.asf.yaml#L39-L41
I don't think that we need to describe them here because each repository should have documentation for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the section.
92d9e36
to
faf07cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Remove outdated instructions for building GLib. Refer to source repositories instead.