Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43785: [Python][CI] Correct PARQUET_TEST_DATA path in wheel tests #43786

Merged

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Aug 22, 2024

Rationale for this change

Starting with #41580, the pyarrow tests now also rely on a file in the parquet-testing submodule. And the path to that directory is controlled by PARQUET_TEST_DATA, which appears to be set wrongly in the wheel test scripts, causing all wheel builds to fail at the moment.

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit -g wheel

Copy link

⚠️ GitHub issue #43785 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Aug 22, 2024
@jorisvandenbossche jorisvandenbossche changed the title GH-43785: [Python][CI] Correct PARQUET_TEST_DATA path in wheel tests GH-43785: [Python][CI] Correct PARQUET_TEST_DATA path in cpp and wheel tests Aug 22, 2024
Copy link

Revision: 04c4735

Submitted crossbow builds: ursacomputing/crossbow @ actions-0d618e3f18

Task Status
wheel-macos-big-sur-cp310-arm64 GitHub Actions
wheel-macos-big-sur-cp311-arm64 GitHub Actions
wheel-macos-big-sur-cp312-arm64 GitHub Actions
wheel-macos-big-sur-cp38-arm64 GitHub Actions
wheel-macos-big-sur-cp39-arm64 GitHub Actions
wheel-macos-catalina-cp310-amd64 GitHub Actions
wheel-macos-catalina-cp311-amd64 GitHub Actions
wheel-macos-catalina-cp312-amd64 GitHub Actions
wheel-macos-catalina-cp38-amd64 GitHub Actions
wheel-macos-catalina-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-arm64 GitHub Actions
wheel-manylinux-2-28-cp311-amd64 GitHub Actions
wheel-manylinux-2-28-cp311-arm64 GitHub Actions
wheel-manylinux-2-28-cp312-amd64 GitHub Actions
wheel-manylinux-2-28-cp312-arm64 GitHub Actions
wheel-manylinux-2-28-cp38-amd64 GitHub Actions
wheel-manylinux-2-28-cp38-arm64 GitHub Actions
wheel-manylinux-2-28-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp39-arm64 GitHub Actions
wheel-manylinux-2014-cp310-amd64 GitHub Actions
wheel-manylinux-2014-cp310-arm64 GitHub Actions
wheel-manylinux-2014-cp311-amd64 GitHub Actions
wheel-manylinux-2014-cp311-arm64 GitHub Actions
wheel-manylinux-2014-cp312-amd64 GitHub Actions
wheel-manylinux-2014-cp312-arm64 GitHub Actions
wheel-manylinux-2014-cp38-amd64 GitHub Actions
wheel-manylinux-2014-cp38-arm64 GitHub Actions
wheel-manylinux-2014-cp39-amd64 GitHub Actions
wheel-manylinux-2014-cp39-arm64 GitHub Actions
wheel-windows-cp310-amd64 GitHub Actions
wheel-windows-cp311-amd64 GitHub Actions
wheel-windows-cp312-amd64 GitHub Actions
wheel-windows-cp38-amd64 GitHub Actions
wheel-windows-cp39-amd64 GitHub Actions

@jorisvandenbossche jorisvandenbossche changed the title GH-43785: [Python][CI] Correct PARQUET_TEST_DATA path in cpp and wheel tests GH-43785: [Python][CI] Correct PARQUET_TEST_DATA path in wheel tests Aug 22, 2024
@apache apache deleted a comment from github-actions bot Aug 22, 2024
@mapleFU
Copy link
Member

mapleFU commented Aug 22, 2024

Thanks for the good catch!

@jorisvandenbossche
Copy link
Member Author

Going to merge this quickly to get nightly wheels uploaded again

@jorisvandenbossche jorisvandenbossche merged commit fc54ead into apache:main Aug 22, 2024
12 checks passed
@jorisvandenbossche jorisvandenbossche removed the awaiting committer review Awaiting committer review label Aug 22, 2024
@jorisvandenbossche jorisvandenbossche deleted the fix-parquet-testing-path branch August 22, 2024 09:28
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit fc54ead.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants