GH-20981: [Flight][Integration] Generic gRPC Test Runner and Server #44115
Conversation
|
|
joellubi
changed the title
joellubi
changed the title
There was a problem hiding this comment.
Yeah I originally had this as auth_basic_proto.go just in case. Then I decided to take a look into the naming rules and was surprised to learn that Go only has requirements for the first character of a filename (source).
| Name: "auth:basic_proto", | ||
| Steps: []scenario.ScenarioStep{ | ||
| { | ||
| Name: "unauthenticated_action", |
There was a problem hiding this comment.
ah, I like this idea of separating out the subcases
There was a problem hiding this comment.
I thought we included the stubs in arrow-go?
There was a problem hiding this comment.
We do, and I was originally using them first started prototyping. As a matter of principle though, I think that this module should avoid relying on any existing arrow implementations (arrow-go in this case) as it could introduce circular logic in tests and make that particular implementation authoritative instead of this suite.
If we only use the generated stubs from arrow-go, that's fine but from go.mod's perspective the entirety of arrow-go is still a dependency. It ends up being the developer's responsibility to not accidentally use non-generated code. By rebuilding the stubs for this module, the arrow-go dependency is removed entirely making the constraint explicit.
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?