Added Schema::independent_canonical_form #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing for now - will reopen when tested on production-like schemas |
|
Fixed nested Ref cases. Added another test |
|
The test failure is not caused by this PR. It is an intermittent error that needs some debugging. |
|
Fixed with #72 |
martin-g
reviewed
Dec 5, 2024
|
I'll try to fully review the PR later today. |
martin-g
reviewed
Dec 11, 2024
Added independent_canonical_from, which populates names available in the schemata, so that the given schema can be used without the schemata
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
martin-g
approved these changes
Jan 20, 2025
|
Thank you, @chupaty ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added independent_canonical_form, which populates types available in the schemata, so that the given schema can be encoded for PCF without the schemata.
See #64