Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3894: [Rust] Record field aliases are not taken into account when serializing #2566

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

martin-g
Copy link
Member

AVRO-3894

What is the purpose of the change

  • Use field's aliases when resolving the types::Value while serializing
  • Also don't treat field's aliases as custom attributes.

Verifying this change

  • All old and new unit tests should pass

Documentation

  • Does this pull request introduce a new feature? no

…n serializing

Also don't treat field's aliases as custom attributes.

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@github-actions github-actions bot added the Rust label Oct 24, 2023
Provided-by: Josua Stingelin

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g force-pushed the avro-3894-take-into-account-aliases branch from 4223b35 to 35033d7 Compare October 25, 2023 06:45
@martin-g martin-g merged commit ec4ca5d into main Oct 25, 2023
15 checks passed
@martin-g martin-g deleted the avro-3894-take-into-account-aliases branch October 25, 2023 07:19
martin-g added a commit that referenced this pull request Oct 25, 2023
…n serializing (#2566)

* AVRO-3894: [Rust] Record field aliases are not taken into account when serializing

Also don't treat field's aliases as custom attributes.

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

* AVRO-3894: [Rust] Add a unit test for schema_compatibility

Provided-by: Josua Stingelin

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

---------

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
(cherry picked from commit ec4ca5d)
RanbirK pushed a commit to RanbirK/avro that referenced this pull request May 13, 2024
…n serializing (apache#2566)

* AVRO-3894: [Rust] Record field aliases are not taken into account when serializing

Also don't treat field's aliases as custom attributes.

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

* AVRO-3894: [Rust] Add a unit test for schema_compatibility

Provided-by: Josua Stingelin

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

---------

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant