AVRO-3901: [Rust] Unit tests and impl for better union support #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
reviewed
Nov 13, 2023
Rename test cases Co-authored-by: Martin Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
|
Thank you, @chupaty ! |
martin-g
pushed a commit
that referenced
this pull request
Nov 14, 2023
* AVRO-3901: Unit tests and impl for better union support * Apply suggestions from code review Rename test cases Co-authored-by: Martin Grigorov <[email protected]> * Cleanup from review * AVRO-3901: Fix formatting, clippy errors and improve naming Signed-off-by: Martin Tzvetanov Grigorov <[email protected]> --------- Signed-off-by: Martin Tzvetanov Grigorov <[email protected]> Co-authored-by: Simon Gittins <[email protected]> Co-authored-by: Martin Grigorov <[email protected]> Co-authored-by: Martin Tzvetanov Grigorov <[email protected]> (cherry picked from commit 85ddfcd)
martin-g
added a commit
that referenced
this pull request
Nov 15, 2023
* AVRO-3901: Unit tests and impl for better union support * Apply suggestions from code review Rename test cases Co-authored-by: Martin Grigorov <[email protected]> * Cleanup from review * AVRO-3901: Fix formatting, clippy errors and improve naming Signed-off-by: Martin Tzvetanov Grigorov <[email protected]> --------- Signed-off-by: Martin Tzvetanov Grigorov <[email protected]> Co-authored-by: Simon Gittins <[email protected]> Co-authored-by: Martin Grigorov <[email protected]> Co-authored-by: Martin Tzvetanov Grigorov <[email protected]>
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
…e#2583) * AVRO-3901: Unit tests and impl for better union support * Apply suggestions from code review Rename test cases Co-authored-by: Martin Grigorov <[email protected]> * Cleanup from review * AVRO-3901: Fix formatting, clippy errors and improve naming Signed-off-by: Martin Tzvetanov Grigorov <[email protected]> --------- Signed-off-by: Martin Tzvetanov Grigorov <[email protected]> Co-authored-by: Simon Gittins <[email protected]> Co-authored-by: Martin Grigorov <[email protected]> Co-authored-by: Martin Tzvetanov Grigorov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVRO-3901
What is the purpose of the change
Demonstrate failing serde serialization and fix for non-trivial union types
Verifying this change
This change added tests and can be verified as follows:
cargo test
Documentation
None added. We're a bit short in this area...