AVRO-4037: [C++] Add local-timestamp-millis, local-timestamp-micros logical types

[glywk]

AVRO-4037

What is the purpose of the change

This pull request adds support of the following logical types as defined since specification 1.10.0:

• local-timestamp-millis
• local-timestamp-micros

Verifying this change

This change added tests and can be verified as follows:

• Extended interop tests to verify consistent valid schema names between SDKs

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

[Gerrit0]

LGTM!

[KalleOlaviNiemitalo]

I worried a bit about potential bugs in conversions between Avro timestamps and std::chrono:: types; but AFAICT this library doesn't implement any such conversions, so it can't have any bugs in them.

[glywk]

I worried a bit about potential bugs in conversions between Avro timestamps and std::chrono:: types; but AFAICT this library doesn't implement any such conversions, so it can't have any bugs in them.

You are right std::chrono::milliseconds and std::chrono::microseconds can be less large chrono::duration than avro long (int64_t). But it is not the aim of this pull request.

[glywk]

@Fokko

[Fokko]

This looks good, thanks @glywk for adding this. Thanks @Gerrit0 and @KalleOlaviNiemitalo for the review 🚀

[Gerrit0]

Looks like one of the errors still mixes - and _

[glywk]

Looks like one of the errors still mixes - and _

Sorry, you are right. It's fixed now.
Thanks for your check.

[glywk]

std::vector definition was not in the right file. It also ease the conan integration (conan-io/conan-center-index#24854)

[martin-g]

Do we want to also add support for [local-]timestamp-nanos too with this PR ?
#2554

[martin-g]

BTW why there is no JIRA for this PR ?
IMO it would be good to have one for the changelog!

[glywk]

BTW why there is no JIRA for this PR ? IMO it would be good to have one for the changelog!

I have no access to JIRA to create one. I have requested one but it was rejected. Can you create one for me? I will request a new one for a next time.

[martin-g]

Can you create one for me?

Sure!

Do we want to also add support for [local-]timestamp-nanos too with this PR ?
#2554

What about this ?

[glywk]

Can you create one for me?

Sure!

Do we want to also add support for [local-]timestamp-nanos too with this PR ?
#2554

What about this ?

• Thanks for the ticket.
• About support of [local-]timestamp-nanos, it is not the aim of this PR. But I propose another one to treat this case. (AVRO-4038: [C++] Add local-timestamp-nanos and timestamp-nanos #3102)

[martin-g]

Thank you, @glywk !