[yaml] add mysql, oracle, postgres and sql server providers #33124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @robertwb |
|
R: @damccorm |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Polber
force-pushed
the
jkinard/jdbc-docs
branch
2 times, most recently
from
e30d1dc to
8056a10
Compare
damccorm
reviewed
Nov 15, 2024
...orm/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadSchemaTransformProvider.java
Show resolved
Hide resolved
.../java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcReadSchemaTransformProvider.java
Outdated
Show resolved
Hide resolved
.../java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcReadSchemaTransformProvider.java
Outdated
Show resolved
Hide resolved
...java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcWriteSchemaTransformProvider.java
Outdated
Show resolved
Hide resolved
...java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcWriteSchemaTransformProvider.java
Show resolved
Hide resolved
.../java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcReadSchemaTransformProvider.java
Show resolved
Hide resolved
damccorm
reviewed
Nov 21, 2024
|
LGTM other than checks failing |
Polber
force-pushed
the
jkinard/jdbc-docs
branch
2 times, most recently
from
1d3e677 to
fd7b354
Compare
Polber
force-pushed
the
jkinard/jdbc-docs
branch
from
8068378 to
09f56e2
Compare
damccorm
reviewed
Dec 23, 2024
| ``` | ||
| - type: MyTransform | ||
| config: | ||
| ... |
There was a problem hiding this comment.
/runner/_work/beam/beam/sdks/python/test-suites/tox/pycommon/build/srcs/sdks/python/target/.tox-docs/docs/lib/python3.9/site-packages/apache_beam/yaml/generate_yaml_docs.py:docstring of apache_beam.yaml.generate_yaml_docs.add_transform_links:11: ERROR: Unexpected indentation.
from docs precommit
Signed-off-by: Jeffrey Kinard <[email protected]>
Signed-off-by: Jeffrey Kinard <[email protected]>
Signed-off-by: Jeffrey Kinard <[email protected]>
Signed-off-by: Jeffrey Kinard <[email protected]>
Signed-off-by: Jeffrey Kinard <[email protected]>
Polber
force-pushed
the
jkinard/jdbc-docs
branch
2 times, most recently
from
f615d16 to
d55eb7b
Compare
Signed-off-by: Jeffrey Kinard <[email protected]>
Polber
force-pushed
the
jkinard/jdbc-docs
branch
from
d55eb7b to
1bfa344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds standalone SchemaTransform Providers for the specific implementations of JDBC (MySQL, PostgreSQL, Oracle and SQL Server).
This was already simulated in the Beam YAML framework, but by implementing concrete providers, other SDKs can take advantage of the pre-packaged drivers (Python and Go SDKs). This also allows for specific doc generation specific to an implementation.
More detailed docs were also added.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.