ISSUE #2377: Relax grpcio requirement for python client to support py…

…thon3.8 on mac os Descriptions of the changes in this PR: Require a grpcio version that is minor of 1.28. This allow to install the 1.27.2 that has a pre-compiled wheel for python 3.8 on mac os. Add tests for python 3.8 ### Motivation grpcio 1.25.0 does not allow the installation using python 3.8 on mac os x. This is due to the fact that the pre-compiled wheels have not been published before 1.26.0 ### Changes Updated the setup.py to relax a bit the requirement for grpcio Add python3.8 as tested version Updated the setup.py to install the latest pymmh3 version. **Note**: master tests are broken, I've updated the library and removed the 'signed' parameter that does not exists not anymore. Master Issue: #<master-issue-number> cc eolivelli Reviewers: Enrico Olivelli <[email protected]>, Sijie Guo <[email protected]> This closes #2432 from ca-simone-chiorazzo/bugfix/2377-relax-grpcio-python-dep-for-python-3.8-on-mac-os, closes #2377 (cherry picked from commit d3af27e) Signed-off-by: Enrico Olivelli <[email protected]>
apache · Oct 14, 2020 · be922fe · be922fe
1 parent c7446b6
commit be922fe
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/stream/clients/python/bookkeeper/common/router/router.py b/stream/clients/python/bookkeeper/common/router/router.py
@@ -27,4 +27,4 @@ def __init__(self):
         return
 
     def getRoutingKey(self, key):
-        return mmh3.hash64(key, seed=__SEED__, signed=True)[0]
+        return mmh3.hash64(key, seed=__SEED__)[0]
diff --git a/stream/clients/python/scripts/test.sh b/stream/clients/python/scripts/test.sh
@@ -19,6 +19,7 @@ set -e -x -u
 
 SCRIPT_DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )
 
+PY_VERSION="3.8" NOXSESSION="unit" ${SCRIPT_DIR}/docker_tests.sh
 PY_VERSION="3.7" NOXSESSION="lint,lint_setup_py,unit" ${SCRIPT_DIR}/docker_tests.sh
 PY_VERSION="3.6" NOXSESSION="unit" ${SCRIPT_DIR}/docker_tests.sh
 PY_VERSION="3.5" NOXSESSION="unit" ${SCRIPT_DIR}/docker_tests.sh

diff --git a/stream/clients/python/setup.py b/stream/clients/python/setup.py
@@ -32,8 +32,8 @@
     'six>=1.10.0',
     'pytz',
     'futures>=3.2.0;python_version<"3.2"',
-    'grpcio<1.26.0,>=1.8.2',
-    'pymmh3>=0.0.3'
+    'grpcio<1.28,>=1.8.2',
+    'pymmh3>=0.0.5'
 ]
 extras = {
 }