Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-5803] Migrate Avatica to Gradle 8.1.1 #221

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

richardantal
Copy link

No description provided.

@snuyanzin
Copy link
Contributor

i wonder if there is anything blocking movement to 8.1.1?

Change-Id: I0456067000e26478693f74942e1e87735ee248c7
@richardantal
Copy link
Author

I am not aware of anything that would block the movement to 8.1.1.
Updated the PR and the ticket accordingly.

@richardantal richardantal changed the title [CALCITE-5803] Migrate Avatica to Gradle 8.0.0 [CALCITE-5803] Migrate Avatica to Gradle 8.1.1 Jun 28, 2023
@richardantal
Copy link
Author

@snuyanzin Can you please review this change or do you know who should I ask?

@snuyanzin
Copy link
Contributor

snuyanzin commented Jun 29, 2023

thanks for asking
i will try to have a look today by the end of the day

@snuyanzin
Copy link
Contributor

It looks ok from my side

the thing I noticed is that ./gradlew tasks is failing...
however I checked that it also fails with 7.6.1, so probably ./gradlew tasks could be done in a follow up task

@snuyanzin
Copy link
Contributor

i will merge it soon
thanks @richardantal

@richardantal
Copy link
Author

Thank you for the review @snuyanzin

I created https://issues.apache.org/jira/browse/CALCITE-5812 to track the ./gradlew tasks problem

@snuyanzin snuyanzin merged commit fc6ce0c into apache:main Jun 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants