Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-5812] Fix failing ./gradlew tasks #222

Closed
wants to merge 1 commit into from
Closed

[CALCITE-5812] Fix failing ./gradlew tasks #222

wants to merge 1 commit into from

Conversation

richardantal
Copy link

No description provided.

@richardantal
Copy link
Author

@zabetak @snuyanzin Can you please review this change?

zabetak
zabetak approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

Can you please also add tasks in a few CI runs as it was done in the calcite repo so that we can catch such problems earlier.

[CALCITE-5812] Fix failing ./gradlew tasks
9738c8d 
Exclude "bom" project from the javadoc aggregation since it does not
have "main" and "test" objects causing "tasks" to fail.

Change-Id: I934ad2b75bf0c109bc85adc0dcb7e4208666605b
@richardantal
Copy link
Author

Sure, I added tasks to a few CI run and rebased the change to the upstream/main .

@zabetak zabetak closed this in be8b99a Jun 30, 2023
@richardantal
Copy link
Author

Thank you for the review and for merging the change.

vijayjogi-dm pushed a commit to datametica/calcite-avatica that referenced this pull request Jun 18, 2024
@vijayjogi-dm
[CALCITE-5812] Gradle tasks fails when creating the javadoc aggregation
2af767b 
Exclude "bom" project from the javadoc aggregation since it does not
have "main" and "test" objects causing "tasks" to fail.

Close apache#222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zabetak zabetak zabetak approved these changes

Assignees
No one assigned
Labels
LGTM and would merge soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardantal @zabetak