[closes #4956] Extend netty-http test coverage #4999
Conversation
avano
force-pushed
the
issue-4956
branch
3 times, most recently
from
18a53e6
to
7979867
Compare
|
it seems that one test is flaky on windows, I'm looking at it |
| .map(h -> h.getKey() + ":" + h.getValue()).collect(Collectors.joining(",")))); | ||
| }); | ||
|
|
||
| from("netty-http:http://localhost:{{camel.netty-http.port}}/response").log("${body}"); |
There was a problem hiding this comment.
I know the test verifies the 200 status code, but maybe we should transform or echo the body back to the client so that we can verify that the route worked as expected.
| @Override | ||
| public Map<String, String> start() { | ||
| // for JVM | ||
| System.setProperty("java.security.auth.login.config", "src/test/resources/config.jaas"); |
There was a problem hiding this comment.
Reading from the source tree will not work when the tests are run in the Quarkus Platform project.
Copy the file to target and use that as the path.
| System.setProperty("java.security.auth.login.config", "src/test/resources/config.jaas"); | ||
| final Map<String, String> properties = super.start(); | ||
| // for native | ||
| properties.put("java.security.auth.login.config", "src/test/resources/config.jaas"); |
There was a problem hiding this comment.
As per previous comment about reading from the source tree.
|
By introducing a new However, that could be non-trivial to do. So not sure if we should address it in this in this PR or do a follow-up. Maybe others have some thoughts on that. There is also this proposal to add the HTTP tests to |
|
@jamesnetherton I can take a look at splitting the http tests in a separate PR |
Sounds good, thanks. Do you mind rebasing with the latest work on main. Just want to make sure everything passes ok with the Quarkus 3.2.0 upgrade. |
after the upgrade to 3.2.0 I needed to register more classes for reflection here |
|
thanks @avano |
No description provided.