Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow invalid host/port values on the vertx-websocket server consumer #5127

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Disallow invalid host/port values on the vertx-websocket server consumer #5127

merged 2 commits into from
Jul 27, 2023

Conversation

jamesnetherton
Copy link
Contributor

/CC @llowinge

@llowinge
Copy link
Contributor

Looks great, thanks @jamesnetherton ! Don't you want to directly remove also https://github.com/apache/camel-quarkus/blob/main/integration-tests/vertx-websocket/src/main/java/org/apache/camel/quarkus/component/vertx/websocket/it/VertxWebsocketRoutes.java#L43 ?

@jamesnetherton jamesnetherton force-pushed the disallow-invalid-consumer-hostport branch from c1c2dbc to bf48ec8 Compare July 27, 2023 11:58
@jamesnetherton
Copy link
Contributor Author

Removed the not needed direct:sendMessage route too.

@jamesnetherton jamesnetherton force-pushed the disallow-invalid-consumer-hostport branch from bf48ec8 to 0ad4653 Compare July 27, 2023 12:00
@jamesnetherton jamesnetherton merged commit 7957347 into apache:main Jul 27, 2023
19 of 20 checks passed
@jamesnetherton jamesnetherton deleted the disallow-invalid-consumer-hostport branch July 27, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldettinger aldettinger aldettinger approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesnetherton @llowinge @oscerd @aldettinger