Manage test container versions in the root project pom.xml #5152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldettinger
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Having a single prop file generated for each test should be ok.
Fingers crossed that all those container version upgrade will pass in ci build 🤞
Also, if one day there is a valid reason to test against multiple release streams of a container, we might be able to use properties like:
kafka-7_x.container.image
kafka-8_x.container.image
jamesnetherton
force-pushed
the
test-container-versions
branch
from
c5cb10c
to
8bf62cc
Compare
ppalaga
reviewed
Aug 7, 2023
tooling/scripts/generate-test-containers-config-properties.groovy
Outdated
Show resolved
Hide resolved
ppalaga
reviewed
Aug 7, 2023
jamesnetherton
force-pushed
the
test-container-versions
branch
from
8bf62cc
to
179f106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tested with the Quarkus Platform and this worked fine.