Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend test coverage of gRPC extension #5168

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Extend test coverage of gRPC extension #5168

merged 3 commits into from
Aug 11, 2023

Conversation

jamesnetherton
Copy link
Contributor

No description provided.

@jamesnetherton
Copy link
Contributor Author

I'll look into the flakiness on Windows.

aldettinger
aldettinger approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done @jamesnetherton 👍

@jamesnetherton jamesnetherton merged commit 01f624f into apache:main Aug 11, 2023
20 checks passed
@jamesnetherton jamesnetherton deleted the grpc-test-coverage branch August 11, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldettinger aldettinger aldettinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesnetherton @aldettinger