-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http: use FIPS complaiant keystore and truststore #5968
Conversation
I add *.pkcs12 and *.ext into ignored files for license check. |
I'd personally vote for not having those certs checked in in git but rather executing the script as a part of Maven build as we do in QCXF In that way, we can stay sure that the script works and it will also keep working 10001 days from now. |
How would that work on Windows? |
It works flawlessly on GH Actions Windows hosts, when shell is set to bash and openssl is installed (no idea how to install it, it's there OOtB on GHA Windows runners). The same works locally for sure. Is that a satisfactory answer? |
Yes it probably uses WSL, which anyone can install. |
Yes., I agree, there is a small hickup, that several modules extend the |
TBH I even thought aboyt placing the generation script in one place in QC repository and use it via several modules. (In theory that should work and would be nicer in my POV) - to not have copies of the generation scripts in several modules |
I have no strong opinion about it. But at some point we should probably discuss our strategy for certificate generation. IMO we should try to make it uniform across the entire project and have it so we can override things like the CN, validity period etc. |
Can we open a new issue for the certification generation? |
I already created the issue (a few days ago) - #5967 |
fixes #5966