Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elasticsearch-rest-client native support #6176

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

jamesnetherton
Copy link
Contributor

No description provided.

Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good addition 👍

Noticed basic auth and multisearch seems uncovered. Not sure it's worth adding native test coverge for this in anoher pr.

@jamesnetherton
Copy link
Contributor Author

Noticed basic auth and multisearch seems uncovered. Not sure it's worth adding native test coverge for this in anoher pr.

That's the 3.22.x documentation for elasticsearch-rest. elasticsearch-rest-client is slightly different. There is no multisearch option.

All of the routes under test use authentication, so that part is covered.

@aldettinger
Copy link
Contributor

Noticed basic auth and multisearch seems uncovered. Not sure it's worth adding native test coverge for this in anoher pr.

That's the 3.22.x documentation for elasticsearch-rest. elasticsearch-rest-client is slightly different. There is no multisearch option.

All of the routes under test use authentication, so that part is covered.

Ok, it's probably the low level rest client. And so the coverage is good. Thanks for explanation @jamesnetherton .

@jamesnetherton jamesnetherton merged commit 3c637f1 into apache:main Jun 11, 2024
24 checks passed
@jamesnetherton jamesnetherton deleted the es-rest-client-native branch June 11, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants