-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump quarkiverse-langchain4j.version from 0.22.0 to 0.23.0 #6894
Bump quarkiverse-langchain4j.version from 0.22.0 to 0.23.0 #6894
Conversation
Bumps `quarkiverse-langchain4j.version` from 0.22.0 to 0.23.0. Updates `io.quarkiverse.langchain4j:quarkus-langchain4j-core` from 0.22.0 to 0.23.0 Updates `io.quarkiverse.langchain4j:quarkus-langchain4j-core-deployment` from 0.22.0 to 0.23.0 Updates `io.quarkiverse.langchain4j:quarkus-langchain4j-ollama` from 0.22.0 to 0.23.0 --- updated-dependencies: - dependency-name: io.quarkiverse.langchain4j:quarkus-langchain4j-core dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.quarkiverse.langchain4j:quarkus-langchain4j-core-deployment dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.quarkiverse.langchain4j:quarkus-langchain4j-ollama dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Warning Branch auto synchronized due to changes in generated files. New workflow run triggered: https://github.com/apache/camel-quarkus/actions/runs/12659606706 Please check the workflow result before merging. |
Windows tests are failing with stack trace below:
@zbendhiba Dev service should not be triggered during langchain4j-chat tests ? As we intend to use mock. Then, the issue could probably be linked to |
I think @jamesnetherton introduced mock because Ollama dev services take too much time to load a model, and it's too slow for CI tests. In Camel core the integration tests are disabled in CI. |
To get this merged, maybe we just disable dev services in the test modules until we have a better way? |
+1 for that |
It's still unclear as for instance windows tests are running well for langchain4j itests but not langchain4j-chat. Let's attempt to disable dev services for langchain4j-chat and see. |
So, disabling ollama dev services for langchain4j-chat makes the pr build happy. And the wiremocked tests for both langchain and langchain4j-chat are running well. From there, merging seems ok unless one has a compelling reason not to. @jamesnetherton How do we generally merge dependabot patched pr ? Simply click |
Yeah, always squash for Dependabot where there are multiple commits. Makes it easier to roll back. |
Bumps
quarkiverse-langchain4j.version
from 0.22.0 to 0.23.0.Updates
io.quarkiverse.langchain4j:quarkus-langchain4j-core
from 0.22.0 to 0.23.0Updates
io.quarkiverse.langchain4j:quarkus-langchain4j-core-deployment
from 0.22.0 to 0.23.0Updates
io.quarkiverse.langchain4j:quarkus-langchain4j-ollama
from 0.22.0 to 0.23.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)