Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump quarkiverse-langchain4j.version from 0.22.0 to 0.23.0 #6894

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 7, 2025

Bumps quarkiverse-langchain4j.version from 0.22.0 to 0.23.0.
Updates io.quarkiverse.langchain4j:quarkus-langchain4j-core from 0.22.0 to 0.23.0

Updates io.quarkiverse.langchain4j:quarkus-langchain4j-core-deployment from 0.22.0 to 0.23.0

Updates io.quarkiverse.langchain4j:quarkus-langchain4j-ollama from 0.22.0 to 0.23.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `quarkiverse-langchain4j.version` from 0.22.0 to 0.23.0.

Updates `io.quarkiverse.langchain4j:quarkus-langchain4j-core` from 0.22.0 to 0.23.0

Updates `io.quarkiverse.langchain4j:quarkus-langchain4j-core-deployment` from 0.22.0 to 0.23.0

Updates `io.quarkiverse.langchain4j:quarkus-langchain4j-ollama` from 0.22.0 to 0.23.0

---
updated-dependencies:
- dependency-name: io.quarkiverse.langchain4j:quarkus-langchain4j-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.quarkiverse.langchain4j:quarkus-langchain4j-core-deployment
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.quarkiverse.langchain4j:quarkus-langchain4j-ollama
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Warning

Branch auto synchronized due to changes in generated files. New workflow run triggered:

https://github.com/apache/camel-quarkus/actions/runs/12659606706

Please check the workflow result before merging.

@aldettinger
Copy link
Contributor

Windows tests are failing with stack trace below:

2025-01-07T22:19:49.8832513Z [INFO] Running org.apache.camel.quarkus.component.langchain4j.chat.it.LangChain4jChatTest
2025-01-07T22:19:57.9466490Z 2025-01-07 22:19:57,888 INFO  [org.tes.DockerClientFactory] (build-27) Testcontainers version: 1.20.4
2025-01-07T22:19:58.5939022Z 2025-01-07 22:19:58,514 INFO  [org.tes.doc.DockerClientProviderStrategy] (build-27) Found Docker environment with local Npipe socket (npipe:////./pipe/docker_engine)
2025-01-07T22:19:58.5940496Z 2025-01-07 22:19:58,514 WARN  [org.tes.doc.DockerClientProviderStrategy] (build-27) windows is currently not supported
...
...
2025-01-07T22:20:21.3951577Z 2025-01-07 22:20:21,381 INFO  [org.tes.ima.PullPolicy] (build-27) Image pull policy will be performed by: DefaultPullPolicy()
2025-01-07T22:20:21.4399651Z 2025-01-07 22:20:21,394 INFO  [org.tes.uti.ImageNameSubstitutor] (build-27) Image name substitution will be performed by: DefaultImageNameSubstitutor (composite of 'ConfigurationFileImageNameSubstitutor' and 'PrefixingImageNameSubstitutor')
2025-01-07T22:20:21.4401537Z 2025-01-07 22:20:21,394 INFO  [org.tes.DockerClientFactory] (build-27) Testcontainers version: 1.20.4
2025-01-07T22:20:21.4851378Z [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 2, Time elapsed: 31.59 s <<< FAILURE! -- in org.apache.camel.quarkus.component.langchain4j.chat.it.LangChain4jChatTest
2025-01-07T22:20:21.4854061Z [ERROR] org.apache.camel.quarkus.component.langchain4j.chat.it.LangChain4jChatTest.simpleMessage -- Time elapsed: 0.016 s <<< ERROR!
2025-01-07T22:20:21.4856766Z java.lang.RuntimeException: 
2025-01-07T22:20:21.4857667Z java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
2025-01-07T22:20:21.4860579Z 	[error]: Build step io.quarkiverse.langchain4j.ollama.deployment.devservices.OllamaDevServicesProcessor#startOllamaDevService threw an exception: java.lang.RuntimeException: java.lang.IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration
2025-01-07T22:20:21.4863791Z 	at io.quarkiverse.langchain4j.ollama.deployment.devservices.OllamaDevServicesProcessor.startOllamaDevService(OllamaDevServicesProcessor.java:109)
2025-01-07T22:20:21.4865622Z 	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
2025-01-07T22:20:21.4866682Z 	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
2025-01-07T22:20:21.4867563Z 	at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
2025-01-07T22:20:21.4868391Z 	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
2025-01-07T22:20:21.4869374Z 	at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)
2025-01-07T22:20:21.4870613Z 	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2654)
2025-01-07T22:20:21.4871743Z 	at org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)
2025-01-07T22:20:21.4872927Z 	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)
2025-01-07T22:20:21.4873846Z 	at java.base/java.lang.Thread.run(Thread.java:840)
2025-01-07T22:20:21.4874525Z 	at org.jboss.threads.JBossThread.run(JBossThread.java:499)
2025-01-07T22:20:21.4875803Z Caused by: java.lang.IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration
2025-01-07T22:20:21.4877740Z 	at org.testcontainers.dockerclient.DockerClientProviderStrategy.getFirstValidStrategy(DockerClientProviderStrategy.java:229)
2025-01-07T22:20:21.4879319Z 	at org.testcontainers.DockerClientFactory.getOrInitializeStrategy(DockerClientFactory.java:154)
2025-01-07T22:20:21.4880600Z 	at org.testcontainers.DockerClientFactory.client(DockerClientFactory.java:196)
2025-01-07T22:20:21.4881721Z 	at org.testcontainers.DockerClientFactory$1.getDockerClient(DockerClientFactory.java:108)
2025-01-07T22:20:21.4882850Z 	at com.github.dockerjava.api.DockerClientDelegate.infoCmd(DockerClientDelegate.java:119)
2025-01-07T22:20:21.4883934Z 	at org.testcontainers.ollama.OllamaContainer.<init>(OllamaContainer.java:35)
2025-01-07T22:20:21.4885188Z 	at io.quarkiverse.langchain4j.ollama.deployment.devservices.OllamaContainer.<init>(OllamaContainer.java:43)
2025-01-07T22:20:21.4886963Z 	at io.quarkiverse.langchain4j.ollama.deployment.devservices.OllamaDevServicesProcessor.startOllama(OllamaDevServicesProcessor.java:167)
2025-01-07T22:20:21.4889141Z 	at io.quarkiverse.langchain4j.ollama.deployment.devservices.OllamaDevServicesProcessor.startOllamaDevService(OllamaDevServicesProcessor.java:99)
2025-01-07T22:20:21.4890502Z 	... 10 more

@zbendhiba Dev service should not be triggered during langchain4j-chat tests ? As we intend to use mock.

Then, the issue could probably be linked to quarkus-langchain4j-ollama dev services being default enabled in 0.23.x ?

@zbendhiba
Copy link
Contributor

I think @jamesnetherton introduced mock because Ollama dev services take too much time to load a model, and it's too slow for CI tests. In Camel core the integration tests are disabled in CI.
I opened an issue worth investigating if we want to have tests running on CI https://issues.apache.org/jira/browse/CAMEL-20936

@jamesnetherton
Copy link
Contributor

To get this merged, maybe we just disable dev services in the test modules until we have a better way?

@zbendhiba
Copy link
Contributor

To get this merged, maybe we just disable dev services in the test modules until we have a better way?

+1 for that

@aldettinger
Copy link
Contributor

It's still unclear as for instance windows tests are running well for langchain4j itests but not langchain4j-chat. Let's attempt to disable dev services for langchain4j-chat and see.

@aldettinger
Copy link
Contributor

So, disabling ollama dev services for langchain4j-chat makes the pr build happy. And the wiremocked tests for both langchain and langchain4j-chat are running well. From there, merging seems ok unless one has a compelling reason not to.

@jamesnetherton How do we generally merge dependabot patched pr ? Simply click Squash and merge is ok ?

@jamesnetherton
Copy link
Contributor

Simply click Squash and merge is ok

Yeah, always squash for Dependabot where there are multiple commits. Makes it easier to roll back.

@aldettinger aldettinger merged commit 7e2dcad into main Jan 9, 2025
24 checks passed
@aldettinger aldettinger deleted the dependabot/maven/quarkiverse-langchain4j.version-0.23.0 branch January 9, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants