JAVA-3098: Improve ability to trace active connections across ControlConnection, BasicLoadBalancingPolicy and NodeRefresh classes #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhughes
force-pushed
the
JAVA-3098
branch
5 times, most recently
from
3111c9c
to
f3dd1c4
Compare
hhughes
commented
Jul 25, 2023
| "[{}] Forcefully closing previous channel {}", logPrefix, channel); | ||
| "[{}] Forcefully closing previous channel {}", | ||
| logPrefix, | ||
| previousChannel); |
There was a problem hiding this comment.
Note: I think this was supposed to be previousChannel so fixing that at the same time
hhughes
commented
Jul 25, 2023
| + liveNodes.dc(dc).stream() | ||
| .map(Objects::toString) | ||
| .collect(Collectors.joining(", "))) | ||
| .collect(Collectors.joining(", "))); |
There was a problem hiding this comment.
let me know if theres a saner way to format these than to put everything into a single line and let the maven plugin figure it out 😅
hhughes
force-pushed
the
JAVA-3098
branch
3 times, most recently
from
d926ccf
to
4411754
Compare
…Connection, BasicLoadBalancingPolicy, DefaultTopologyMonitor and NodeRefresh classes
|
Moved to PR from fork see #1711 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.