CASSJAVA-40: Driver testing against Java 21 #1999
Open
+31
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…before run tests
SiyaoIsHiding
commented
Dec 24, 2024
| @@ -77,7 +78,7 @@ public static <ElementT> void shuffleHead(@NonNull ElementT[] elements, int n) { | |||
| * Fisher-Yates shuffle</a> | |||
| */ | |||
| public static <ElementT> void shuffleHead( | |||
| @NonNull ElementT[] elements, int n, @NonNull ThreadLocalRandom random) { | |||
| @NonNull ElementT[] elements, int n, @NonNull Random random) { | |||
There was a problem hiding this comment.
Mockito says they can no longer support mocking of ThreadLocalRandom.
This fix will also close JAVA-3137.
SiyaoIsHiding
commented
Dec 24, 2024
| @@ -79,7 +79,7 @@ public class QueryTraceFetcherTest { | |||
| @Mock private NettyOptions nettyOptions; | |||
| @Mock private EventExecutorGroup adminEventExecutorGroup; | |||
| @Mock private EventExecutor eventExecutor; | |||
| @Mock private InetAddress address; | |||
| private InetAddress address = InetAddress.getLoopbackAddress(); | |||
There was a problem hiding this comment.
Mockito can no longer mock InetAddress as it becomes final in newer JDK versions.
|
The three runs about JDK 21 all got green: https://ci-cassandra.apache.org/blue/organizations/jenkins/cassandra-java-driver-mck/detail/java21/10/pipeline/ |
SiyaoIsHiding
commented
Dec 24, 2024
| @@ -409,7 +410,16 @@ protected void processLine(String line, int logLevel) { | |||
| executor.setStreamHandler(streamHandler); | |||
| executor.setWatchdog(watchDog); | |||
|
|
|||
| int retValue = executor.execute(cli); | |||
| int retValue; | |||
There was a problem hiding this comment.
I modified CcmBridge because the latest commit on guava shaded broke the CI, cuz some how there are two source files that are not compiled in mvn install but compiled in mvn verify. Maybe we need to figure out why that happens and fix that instead, and revert the CcmBridge changes here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: change the docker image name to "apache.jfrog.io/cassan-docker/apache/cassandra-java-driver-testing-ubuntu2204" after Mick update the docker image.