Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved performance of UriParser#extractScheme #614

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+7 −1
Open

Improved performance of UriParser#extractScheme #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
424876f
Improved performance of UriParser.normalisePath
japplis May 29, 2024
52d091a
Improved performance of UriParser.extractScheme
japplis May 31, 2024
977a3ca
Merge branch 'master' into uri-parser-extract-scheme-perf
japplis Jul 30, 2024
0cd79dc
Merge branch 'master' into uri-parser-extract-scheme-perf
japplis Oct 5, 2024
8ddf3f0
Aligned measurement with master branch
japplis Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/UriParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ public static String extractScheme(final String[] schemes, final String uri, fin
buffer.append(uri);
}
for (final String scheme : schemes) {
if (uri.startsWith(scheme + ":")) {
if (uri.startsWith(scheme) && uri.length() > scheme.length() && uri.charAt(scheme.length()) == ':') {
if (buffer != null) {
buffer.delete(0, uri.indexOf(':') + 1);
}
Expand Down
6 changes: 6 additions & 0 deletions commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/UriParserBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,17 @@
public class UriParserBenchmark {

private static final String PATH_TO_NORMALIZE = "file:///this/../is/a%2flong%2Fpath/./for testing/normlisePath%2fmethod.txt";
private static final String[] SCHEMES = {"file", "ftp", "ftps", "webdav", "temp", "ram", "http", "https", "sftp", "zip", "jar", "tgz", "gz"};

@Benchmark
public void normalisePath() throws FileSystemException {
final StringBuilder path = new StringBuilder(PATH_TO_NORMALIZE);
UriParser.fixSeparators(path);
UriParser.normalisePath(path);
}

@Benchmark
public void extractScheme() throws FileSystemException {
UriParser.extractScheme(SCHEMES, PATH_TO_NORMALIZE);
}
}