Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove gulp-util dependency #1376

Merged
merged 4 commits into from
Nov 2, 2024
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Nov 2, 2024

Platforms affected

n/a

Motivation and Context

Remove deprecated gulp-util: https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5

Description

  • Removed gulp-util
  • Replaced gutil.env.log with custom util logger method.
  • Replaced gutil.colors with node:util styleText method.
  • Replaced gutil.env with minimist

Testing

  • npm run test
  • npm run clean
  • npm run build
  • npm run build -- --nofetch
  • npm run build:prod
  • npm run build:prod -- --nodocs
  • npm run lint
  • npm run update-docs
  • npm run serve

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erisu erisu merged commit 746d8b9 into apache:master Nov 2, 2024
1 check passed
@erisu erisu deleted the feat/remove-gulp-util branch November 2, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants