-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: cleanup & refactor dependency usage #1378
feat!: cleanup & refactor dependency usage #1378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be possible to replace minimist
with node:util/parseArgs
for these simple cases, but I think that would require you to handle checking for required options yourself.
@@ -272,7 +272,7 @@ img#logo_top { | |||
} | |||
|
|||
.supported_platforms { | |||
background-color: darken(white, 85%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is happening on a static colour white
we should just figure out what the hex value is and use it directly or store it directly in a variable instead of needing a colour function here.
@@ -293,7 +293,7 @@ img#logo_top { | |||
.card { | |||
padding:8px; | |||
.card_inner { | |||
background-color: darken(white, 85%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too, since this is happening on a static colour white
we should just figure out what the hex value is and use it directly or store it directly in a variable instead of needing a colour function here.
Platforms affected
n/a
Motivation and Context
Description
optimist
& replaced withminimist
+ custom wrapper.fs-extra
fornode:fs
chalk
fornode:util
styleText
node:*
ncp
forfs.cp
gulp-less
- No less files in repobaconjs
- Not used anywhere@babel/core
&@babel/preset-react
- Not used anywhere.preact
&preact-compat
- Not used anywhere. Last usage was prior to plugin search page redesign.classnames
- Not used anywhere. Last usage was prior to plugin search page redesign.sass
&gulp-sass
dependenciessemver
@cordova/[email protected]
w/ lint fixv20.18.0
sass
lint warnings withdarken
andlighten
Testing
npm t
npm run serve
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)