Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: cleanup & refactor dependency usage #1378

Merged
merged 17 commits into from
Nov 8, 2024

Conversation

erisu
Copy link
Member

@erisu erisu commented Nov 6, 2024

Platforms affected

n/a

Motivation and Context

  • Remove unused dependencies
  • Reduce dependencies footprint for node internals

Description

  • Remove optimist & replaced with minimist + custom wrapper.
  • Remove fs-extra for node:fs
  • Remove chalk for node:util styleText
  • Prefixed node internal packages with node:*
  • Remove ncp for fs.cp
  • Remove gulp-less - No less files in repo
  • Remove baconjs - Not used anywhere
  • Remove @babel/core & @babel/preset-react - Not used anywhere.
  • Remove preact & preact-compat - Not used anywhere. Last usage was prior to plugin search page redesign.
  • Remove classnames - Not used anywhere. Last usage was prior to plugin search page redesign.
  • Updated sass & gulp-sass dependencies
  • Updated semver
  • Updated @cordova/[email protected] w/ lint fix
  • Bump node engine requirement to v20.18.0
  • Resolve sass lint warnings with darken and lighten

Testing

  • npm t
  • npm run serve

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be possible to replace minimist with node:util/parseArgs for these simple cases, but I think that would require you to handle checking for required options yourself.

@@ -272,7 +272,7 @@ img#logo_top {
}

.supported_platforms {
background-color: darken(white, 85%);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is happening on a static colour white we should just figure out what the hex value is and use it directly or store it directly in a variable instead of needing a colour function here.

@@ -293,7 +293,7 @@ img#logo_top {
.card {
padding:8px;
.card_inner {
background-color: darken(white, 85%);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too, since this is happening on a static colour white we should just figure out what the hex value is and use it directly or store it directly in a variable instead of needing a colour function here.

@erisu erisu merged commit e9730df into apache:master Nov 8, 2024
1 check passed
@erisu erisu deleted the feat/cleanup-and-refactor-dependency-usage branch November 8, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants