Skip to content

Commit

Permalink
refactor!(SPM): rename Swift package from CordovaLib to Cordova
Browse files Browse the repository at this point in the history
This ends up being less confusing for everyone because the resulting
framework is named Cordova.framework and the header paths are all
<Cordova/*.h> but currently you need to reference the Swift dependency
as "CordovaLib" rather than "Cordova".

As far as I can tell from a quick search of public Package.swift files
on GitHub, nobody has actually consumed this as a Swift package, so any
breakage should be minimal and we should take the opportunity to do this
right as part of the major version bump.
  • Loading branch information
dpogue committed Jan 16, 2025
1 parent 82c1767 commit d3bfa6f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ let package = Package(
.macCatalyst(.v13)
],
products: [
.library(name: "CordovaLib", targets: ["Cordova"])
.library(name: "Cordova", targets: ["Cordova"])
],
dependencies: [],
targets: [
Expand Down
10 changes: 5 additions & 5 deletions templates/project/App.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
907F98562C06B87200D2D242 /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = 907F98552C06B87200D2D242 /* PrivacyInfo.xcprivacy */; };
907F98662C06BC1B00D2D242 /* config.xml in Resources */ = {isa = PBXBuildFile; fileRef = 907F98652C06BC1B00D2D242 /* config.xml */; };
907F986A2C06BCD300D2D242 /* www in Resources */ = {isa = PBXBuildFile; fileRef = 907F98692C06BCD300D2D242 /* www */; };
90A914592CA3D370003DB979 /* CordovaLib in Frameworks */ = {isa = PBXBuildFile; productRef = 90A914582CA3D370003DB979 /* CordovaLib */; };
90A914592CA3D370003DB979 /* Cordova in Frameworks */ = {isa = PBXBuildFile; productRef = 90A914582CA3D370003DB979 /* Cordova */; };
90BD9B7A2C06907D000DEBAB /* Base in Resources */ = {isa = PBXBuildFile; fileRef = 90BD9B792C06907D000DEBAB /* Base */; };
90BD9B7C2C06907E000DEBAB /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 90BD9B7B2C06907E000DEBAB /* Assets.xcassets */; };
90BD9B7F2C06907E000DEBAB /* Base in Resources */ = {isa = PBXBuildFile; fileRef = 90BD9B7E2C06907E000DEBAB /* Base */; };
Expand Down Expand Up @@ -80,7 +80,7 @@
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
90A914592CA3D370003DB979 /* CordovaLib in Frameworks */,
90A914592CA3D370003DB979 /* Cordova in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down Expand Up @@ -190,7 +190,7 @@
);
name = App;
packageProductDependencies = (
90A914582CA3D370003DB979 /* CordovaLib */,
90A914582CA3D370003DB979 /* Cordova */,
);
productName = App;
productReference = 90BD9B6C2C06907D000DEBAB /* App.app */;
Expand Down Expand Up @@ -528,9 +528,9 @@
/* End XCLocalSwiftPackageReference section */

/* Begin XCSwiftPackageProductDependency section */
90A914582CA3D370003DB979 /* CordovaLib */ = {
90A914582CA3D370003DB979 /* Cordova */ = {
isa = XCSwiftPackageProductDependency;
productName = CordovaLib;
productName = Cordova;
};
/* End XCSwiftPackageProductDependency section */
};
Expand Down

0 comments on commit d3bfa6f

Please sign in to comment.