refactor!(SPM): rename Swift package from CordovaLib to Cordova #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ends up being less confusing for everyone because the resulting framework is named Cordova.framework and the header paths are all <Cordova/*.h> but currently you need to reference the Swift dependency as "CordovaLib" rather than "Cordova". As far as I can tell from a quick search of public Package.swift files on GitHub, nobody has actually consumed this as a Swift package, so any breakage should be minimal and we should take the opportunity to do this right as part of the major version bump.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1520 +/- ##
=======================================
Coverage 81.34% 81.34%
=======================================
Files 16 16
Lines 1855 1855
=======================================
Hits 1509 1509
Misses 346 346 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Description
This ends up being less confusing for everyone because the resulting framework is named Cordova.framework and the header paths are all
<Cordova/*.h>but currently you need to reference the Swift dependency as "CordovaLib" rather than "Cordova".As far as I can tell from a quick search of public Package.swift files on GitHub, nobody has actually consumed this as a Swift package, so any breakage should be minimal and we should take the opportunity to do this right as part of the major version bump.
Testing
Existing tests pass.
Checklist