-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set cancelable to false by default on Android #56
base: master
Are you sure you want to change the base?
Conversation
To match with the iOS behavior where all modals cannot be canceled by a click outside of it (or a back button). First of all, there is no case where it is interesting for the developper to let the user dismiss the modal by a simple click outside of the modal. And it's absolutely not user friendly, the user does not attempt to see the modal closing after this action. Here some testimonies of developers that have trouble with this (not only with cordova) : jquery-archive/jquery-mobile#4727 http://stackoverflow.com/questions/23300122/prevent-phonegap-notification-navigator-popups-from-closing-from-touch-outside-o http://programming.nullanswer.com/question/27626010 http://iswwwup.com/t/5fcbb227c8f7/javascript-prevent-kendo-tooltip-hide-close-when-clicking-outside-the-tooltip.html
++ |
++ @RomainFallet maybe you could simply update the calls to |
I just saw #60 that actually added a |
++ |
++ |
any news on it? |
Any news? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard conflict, so this can't be merged directly. Either @RomainFallet rebases and fixes the conflicts, or someone has to create a new PR with theses changes based on current master
.
Caution: This would be a breaking, major change as it changes current behavior.
To match with the iOS behavior where all modals cannot be canceled by a click outside of it (or a back button).
First of all, there is few case where it is interesting for the developper to let the user dismiss the modal by a simple click outside of the modal. And it's absolutely not user friendly, the user does not attempt to see the modal closing after this action. He can cancel it unintentionally.
Maybe a setting would be a great solution too ?
Here some testimonies of developers that have trouble with this (not only with cordova) :
jquery-archive/jquery-mobile#4727
http://stackoverflow.com/questions/23300122/prevent-phonegap-notification-navigator-popups-from-closing-from-touch-outside-o
http://programming.nullanswer.com/question/27626010
http://iswwwup.com/t/5fcbb227c8f7/javascript-prevent-kendo-tooltip-hide-close-when-clicking-outside-the-tooltip.html