fix(android): Request permission Android <= 10 on API 33 #587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Motivation and Context
On Android 10 and below, on cordova-plugin-file V8 and cordova-android V12 the permission request was not displayed to the user witch lead to an error when trying to write a file in the externalRootDirectory + '/Download' folder.
Permission not requested on Android 10 when targeting API 33 (#586)
Description
This fix always ask for permission if needed on GetFile action. This allow to fix the bug.
Testing
I test on Android 10/11/12/13 that writing a file to externalRootDirectory + '/Download' works.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)