Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalafmt-core to 3.7.15 #1101

Closed

Conversation

scala-steward
Copy link
Contributor

About this PR

πŸ“¦ Updates org.scalameta:scalafmt-core from 3.7.14 to 3.7.15

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

- Changes to how we use invalid surrogate pairs in string literals in
  tests. Scalafmt detects them so we must create invalid surrogate pairs
  manually.
@stevedlawrence stevedlawrence force-pushed the update/scalafmt-core-3.7.15 branch from ffdc644 to c99a069 Compare November 9, 2023 19:44
Copy link
Member

@stevedlawrence stevedlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

  • Do all automated continuous integration checks pass?
    Had to fix an issue with scalafmt not liking invalid surrogate pairs in string literals. They don't mention this in the changelog that I see, so it might be incidental to another change, but it does seem reasonable to error on invalid strings. Tests rerunning with the change now
  • Is the update a patch, minor, or major update?
    Patch update, no change affects Daffodil aside from surrogate pair failure
  • Is the license still compatible with ASF License Policy?
    Yes, ALv2
  • Have any changes been made to LICENSE/NOTICE files that need to be incorporated?
    Not applicable, we do not distribute
  • Have any transitive dependencies been added or changed?
    Not applicable, we do not distribute

@scala-steward
Copy link
Contributor Author

Superseded by #1114.

@scala-steward scala-steward deleted the update/scalafmt-core-3.7.15 branch November 11, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants