Use encodingErrorPolicy replace, even when set to error #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuxji
approved these changes
Dec 11, 2023
mbeckerle
approved these changes
Dec 12, 2023
daffodil-test/src/test/resources/org/apache/daffodil/section00/general/tunables.tdml
Outdated
Show resolved
Hide resolved
If encodingErrorPolicy="error" we print a warning letting the user know it is not supported and that we will use "replace" instead. This is so that we can support schemas written for IBM DFDL (which only supports "error") and have the exact same behavior as IBM DFDL except for when data has encoding errors, which is usually rare. However, even though we warn that we will use "replace", we do not actually do so, which leads to an assertion exception if there are encoding errors. This fixes that so our behavior matches the warning message and we always use "replace". DAFFODIL-2861
stevedlawrence
force-pushed
the
daffodil-2861-encodingErrorPolicy-error
branch
from
0612bfc to
2fe944a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If encodingErrorPolicy="error" we print a warning letting the user know it is not supported and that we will use "replace" instead. This is so that we can support schemas written for IBM DFDL (which only supports "error") and have the exact same behavior as IBM DFDL except for when data has encoding errors, which is usually rare.
However, even though we warn that we will use "replace", we do not actually do so, which leads to an assertion exception if there are encoding errors. This fixes that so our behavior matches the warning message and we always use "replace".
DAFFODIL-2861