Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate select_columns #911

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

ion-elgreco
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

Aliases in my opinion bloat the API, in this case it's also just nearly the same as select so we can just deprecate it and only keep select as that is clear enough. This will also improve code readability when you look at datafusion code.

What changes are included in this PR?

  • marks select_columns as deprecated

Are there any user-facing changes?

  • marks select_columns as deprecated

@timsaucer
Copy link
Contributor

We need to update docs in docs/source/user-guide/common-operations/select-and-filter.rst to no longer user select_columns since it's marked as deprecated

@ion-elgreco
Copy link
Contributor Author

We need to update docs in docs/source/user-guide/common-operations/select-and-filter.rst to no longer user select_columns since it's marked as deprecated

Noted, will fix it once I'm back

@timsaucer
Copy link
Contributor

These are trivial diffs, so I'll update them and ask @Michael-J-Ward to give a once over. Thank you again for all the PRs!

@timsaucer timsaucer merged commit 56b7243 into apache:main Oct 22, 2024
15 checks passed
@Michael-J-Ward
Copy link
Contributor

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants