-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Convert
approx_median to UDAF (#10840)
* move tdigest to physical-expr-common * move approx_percentile_cont_accumulator to function-aggregate * implement approx_meidan udaf * remove approx_median aggregation function * fix sqllogictests * add removed type tests * cargo fmt and clippy * add logical roundtrip test * fix dataframe test * fix test and proto gen * update lock in datafusion-cli * fix typo * fix test and doc * fix sql_integration * cargo fmt * follow the checking style like other udaf * add comment and modified dependency * update lock and fmt * add missing test annotation
- Loading branch information
Showing
26 changed files
with
471 additions
and
497 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| //! Defines physical expressions for APPROX_MEDIAN that can be evaluated MEDIAN at runtime during query execution | ||
|
|
||
| use std::any::Any; | ||
| use std::fmt::Debug; | ||
|
|
||
| use arrow::{datatypes::DataType, datatypes::Field}; | ||
| use arrow_schema::DataType::{Float64, UInt64}; | ||
|
|
||
| use datafusion_common::{not_impl_err, plan_err, Result}; | ||
| use datafusion_expr::function::{AccumulatorArgs, StateFieldsArgs}; | ||
| use datafusion_expr::type_coercion::aggregates::NUMERICS; | ||
| use datafusion_expr::utils::format_state_name; | ||
| use datafusion_expr::{Accumulator, AggregateUDFImpl, Signature, Volatility}; | ||
| use datafusion_physical_expr_common::aggregate::utils::down_cast_any_ref; | ||
|
|
||
| use crate::approx_percentile_cont::ApproxPercentileAccumulator; | ||
|
|
||
| make_udaf_expr_and_func!( | ||
| ApproxMedian, | ||
| approx_median, | ||
| expression, | ||
| "Computes the approximate median of a set of numbers", | ||
| approx_median_udaf | ||
| ); | ||
|
|
||
| /// APPROX_MEDIAN aggregate expression | ||
| pub struct ApproxMedian { | ||
| signature: Signature, | ||
| } | ||
|
|
||
| impl Debug for ApproxMedian { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { | ||
| f.debug_struct("ApproxMedian") | ||
| .field("name", &self.name()) | ||
| .field("signature", &self.signature) | ||
| .finish() | ||
| } | ||
| } | ||
|
|
||
| impl Default for ApproxMedian { | ||
| fn default() -> Self { | ||
| Self::new() | ||
| } | ||
| } | ||
|
|
||
| impl ApproxMedian { | ||
| /// Create a new APPROX_MEDIAN aggregate function | ||
| pub fn new() -> Self { | ||
| Self { | ||
| signature: Signature::uniform(1, NUMERICS.to_vec(), Volatility::Immutable), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl AggregateUDFImpl for ApproxMedian { | ||
| /// Return a reference to Any that can be used for downcasting | ||
| fn as_any(&self) -> &dyn Any { | ||
| self | ||
| } | ||
|
|
||
| fn state_fields(&self, args: StateFieldsArgs) -> Result<Vec<Field>> { | ||
| Ok(vec![ | ||
| Field::new(format_state_name(args.name, "max_size"), UInt64, false), | ||
| Field::new(format_state_name(args.name, "sum"), Float64, false), | ||
| Field::new(format_state_name(args.name, "count"), Float64, false), | ||
| Field::new(format_state_name(args.name, "max"), Float64, false), | ||
| Field::new(format_state_name(args.name, "min"), Float64, false), | ||
| Field::new_list( | ||
| format_state_name(args.name, "centroids"), | ||
| Field::new("item", Float64, true), | ||
| false, | ||
| ), | ||
| ]) | ||
| } | ||
|
|
||
| fn name(&self) -> &str { | ||
| "approx_median" | ||
| } | ||
|
|
||
| fn signature(&self) -> &Signature { | ||
| &self.signature | ||
| } | ||
|
|
||
| fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> { | ||
| if !arg_types[0].is_numeric() { | ||
| return plan_err!("ApproxMedian requires numeric input types"); | ||
| } | ||
| Ok(arg_types[0].clone()) | ||
| } | ||
|
|
||
| fn accumulator(&self, acc_args: AccumulatorArgs) -> Result<Box<dyn Accumulator>> { | ||
| if acc_args.is_distinct { | ||
| return not_impl_err!( | ||
| "APPROX_MEDIAN(DISTINCT) aggregations are not available" | ||
| ); | ||
| } | ||
|
|
||
| Ok(Box::new(ApproxPercentileAccumulator::new( | ||
| 0.5_f64, | ||
| acc_args.input_type.clone(), | ||
| ))) | ||
| } | ||
| } | ||
|
|
||
| impl PartialEq<dyn Any> for ApproxMedian { | ||
| fn eq(&self, other: &dyn Any) -> bool { | ||
| down_cast_any_ref(other) | ||
| .downcast_ref::<Self>() | ||
| .map(|x| self.signature == x.signature) | ||
| .unwrap_or(false) | ||
| } | ||
| } |
Oops, something went wrong.