Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Modify docs to fix old naming #10199

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Doc: Modify docs to fix old naming #10199

merged 6 commits into from
Apr 23, 2024

Conversation

comphead
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Apr 23, 2024
@comphead
Copy link
Contributor Author

Related to #9691

dev/release/README.md Outdated Show resolved Hide resolved
dev/release/README.md Outdated Show resolved Hide resolved
dev/release/README.md Outdated Show resolved Hide resolved
@@ -37,7 +37,7 @@ We use the Slack and Discord platforms for informal discussions and coordination
meet other contributors and get guidance on where to contribute. It is important to note that any technical designs and
decisions are made fully in the open, on GitHub.

Most of us use the `#arrow-datafusion` and `#arrow-rust` channels in the [ASF Slack workspace](https://s.apache.org/slack-invite) .
Most of us use the `#datafusion` and `#arrow-rust` channels in the [ASF Slack workspace](https://s.apache.org/slack-invite) .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just renamed the slack channel to match this documentation change

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @comphead. I left a few suggested changes.

comphead and others added 3 commits April 23, 2024 08:52
@comphead
Copy link
Contributor Author

Thanks for the review @andygrove

@comphead comphead changed the title Fix docs on datafusion names Doc: Modify docs to fix old naming Apr 23, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @comphead and @andygrove

@@ -223,7 +223,7 @@ Here is my vote:
+1

[1]: https://github.com/apache/datafusion/tree/a5dd428f57e62db20a945e8b1895de91405958c4
[2]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-5.1.0
[2]: https://dist.apache.org/repos/dist/dev/arrow/apache-datafusion-5.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite right (this path doesn't exist) but I think it will be fixed when we update the release scripts

@comphead
Copy link
Contributor Author

Thanks all for the review 👍

@comphead comphead merged commit 5d44685 into apache:main Apr 23, 2024
25 checks passed
ccciudatu pushed a commit to hstack/arrow-datafusion that referenced this pull request Apr 26, 2024
* fix docs on datafusion names

* fix code

* fmt

* Update dev/release/README.md

Co-authored-by: Andy Grove <[email protected]>

* Update dev/release/README.md

Co-authored-by: Andy Grove <[email protected]>

* Update dev/release/README.md

Co-authored-by: Andy Grove <[email protected]>

---------

Co-authored-by: Andy Grove <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants