-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Modify docs to fix old naming #10199
Conversation
Related to #9691 |
@@ -37,7 +37,7 @@ We use the Slack and Discord platforms for informal discussions and coordination | |||
meet other contributors and get guidance on where to contribute. It is important to note that any technical designs and | |||
decisions are made fully in the open, on GitHub. | |||
|
|||
Most of us use the `#arrow-datafusion` and `#arrow-rust` channels in the [ASF Slack workspace](https://s.apache.org/slack-invite) . | |||
Most of us use the `#datafusion` and `#arrow-rust` channels in the [ASF Slack workspace](https://s.apache.org/slack-invite) . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just renamed the slack channel to match this documentation change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @comphead. I left a few suggested changes.
Co-authored-by: Andy Grove <[email protected]>
Co-authored-by: Andy Grove <[email protected]>
Co-authored-by: Andy Grove <[email protected]>
Thanks for the review @andygrove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @comphead and @andygrove
@@ -223,7 +223,7 @@ Here is my vote: | |||
+1 | |||
|
|||
[1]: https://github.com/apache/datafusion/tree/a5dd428f57e62db20a945e8b1895de91405958c4 | |||
[2]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-5.1.0 | |||
[2]: https://dist.apache.org/repos/dist/dev/arrow/apache-datafusion-5.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't quite right (this path doesn't exist) but I think it will be fixed when we update the release scripts
Thanks all for the review 👍 |
* fix docs on datafusion names * fix code * fmt * Update dev/release/README.md Co-authored-by: Andy Grove <[email protected]> * Update dev/release/README.md Co-authored-by: Andy Grove <[email protected]> * Update dev/release/README.md Co-authored-by: Andy Grove <[email protected]> --------- Co-authored-by: Andy Grove <[email protected]>
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?