Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add download page #10271

Merged
merged 3 commits into from
Apr 30, 2024
Merged

docs: add download page #10271

merged 3 commits into from
Apr 30, 2024

Conversation

tisonkun
Copy link
Member

Which issue does this PR close?

Closes #10236

docs/source/download.md Outdated Show resolved Hide resolved
@tisonkun tisonkun force-pushed the download-page branch 2 times, most recently from e5cd047 to ec88d22 Compare April 28, 2024 14:44
docs/source/download.md Outdated Show resolved Hide resolved
@tisonkun
Copy link
Member Author

@andygrove Updated. It should be fine to merge now. And perhaps our release manual should contain a step to update the download page with the latest version link.

docs/source/download.md Outdated Show resolved Hide resolved
Copy link
Contributor

@phillipleblanc phillipleblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I have some minor rewording suggestions.

docs/source/download.md Outdated Show resolved Hide resolved
docs/source/download.md Outdated Show resolved Hide resolved
@tisonkun
Copy link
Member Author

@phillipleblanc Thank you! Integrated.

docs/source/download.md Outdated Show resolved Hide resolved
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tisonkun
Minor comments

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks (again!) @tisonkun -- I think it would be good to also mention crates.io (I left a suggestion) but I also think we could fix that as a follow on PR as well

docs/source/download.md Outdated Show resolved Hide resolved
@tisonkun
Copy link
Member Author

@comphead @alamb Thanks for your suggestions. Integrated.

Co-authored-by: Andrew Lamb <[email protected]>
Signed-off-by: tison <[email protected]>
@alamb
Copy link
Contributor

alamb commented Apr 30, 2024

Looks great to me -- thank you @tisonkun @phillipleblanc @andygrove @sebbASF and @comphead -- a very nice new page indeed!

@alamb alamb merged commit 5deefd5 into apache:main Apr 30, 2024
4 checks passed
@alamb alamb added the documentation Improvements or additions to documentation label Apr 30, 2024
@tisonkun tisonkun deleted the download-page branch April 30, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding a "Downloads" page
6 participants