-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement equality = and inequality <> support for StringView #10985
Merged
alamb
merged 8 commits into
apache:string-view
from
Weijun-H:support-equality-for-stringview
Jun 19, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
227fc39
feat: Implement equality = and inequality <> support for StringView
Weijun-H 9a9006c
chore: Add tests for the StringView
Weijun-H 5930faa
chore
Weijun-H e36a93e
chore: Update tests for NULL
Weijun-H 0f0de6d
fix: Used build_array_string!
Weijun-H 6659d04
chore: Update string_coercion function to handle Utf8View type in bin…
Weijun-H 308075d
chore: add tests
Weijun-H 94ede95
chore: ci
Weijun-H File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
|
|
||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
|
|
||
| # test StringViewArray with Utf8View columns | ||
| statement ok | ||
| create table test as values (arrow_cast('Andrew', 'Utf8View'), arrow_cast('X', 'Utf8View')), | ||
| (arrow_cast('Xiangpeng', 'Utf8View'), arrow_cast('Xiangpeng', 'Utf8View')), | ||
| (arrow_cast('Raphael', 'Utf8View'), arrow_cast('R', 'Utf8View')), | ||
| (arrow_cast(NULL, 'Utf8View'), arrow_cast('R', 'Utf8View')); | ||
|
|
||
| query B | ||
| select arrow_cast('NULL', 'Utf8View') = arrow_cast('Andrew', 'Utf8View'); | ||
| ---- | ||
| false | ||
|
|
||
| query B | ||
| select arrow_cast('NULL', 'Utf8View') <> arrow_cast('Andrew', 'Utf8View'); | ||
| ---- | ||
| true | ||
|
|
||
| query B | ||
| select arrow_cast('Andrew', 'Utf8View') = arrow_cast('Andrew', 'Utf8View'); | ||
| ---- | ||
| true | ||
|
|
||
| query B | ||
| select arrow_cast('Xiangpeng', 'Utf8View') <> arrow_cast('Andrew', 'Utf8View'); | ||
| ---- | ||
| true | ||
|
|
||
| query ?? | ||
| select * from test where column1 = column2; | ||
| ---- | ||
| Xiangpeng Xiangpeng | ||
|
|
||
| query ?? | ||
| select * from test where column1 <> column2; | ||
| ---- | ||
| Andrew X | ||
| Raphael R | ||
|
|
||
| query ?? | ||
| select * from test where column1 = arrow_cast('Andrew', 'Utf8View'); | ||
| ---- | ||
| Andrew X | ||
|
|
||
| query ?? | ||
| select * from test where column1 = 'Andrew'; | ||
| ---- | ||
| Andrew X | ||
|
|
||
| query ?? | ||
| select * from test where column1 <> arrow_cast('Andrew', 'Utf8View'); | ||
| ---- | ||
| Xiangpeng Xiangpeng | ||
| Raphael R | ||
|
|
||
| query ?? | ||
| select * from test where column1 <> 'Andrew'; | ||
| ---- | ||
| Xiangpeng Xiangpeng | ||
| Raphael R | ||
|
|
||
| statement ok | ||
| drop table test; | ||
|
|
||
|
|
||
| # test StringViewArray with Utf8 and Utf8View columns | ||
| statement ok | ||
| create table test as values ('Andrew', arrow_cast('X', 'Utf8View')), | ||
| ('Xiangpeng', arrow_cast('Xiangpeng', 'Utf8View')), | ||
| ('Raphael', arrow_cast('R', 'Utf8View')), | ||
| (NULL, arrow_cast('R', 'Utf8View')); | ||
|
|
||
| query T? | ||
| select * from test where column1 = column2; | ||
| ---- | ||
| Xiangpeng Xiangpeng | ||
|
|
||
| query T? | ||
| select * from test where column1 <> column2; | ||
| ---- | ||
| Andrew X | ||
| Raphael R | ||
|
|
||
| query T? | ||
| select * from test where column1 = arrow_cast('Andrew', 'Utf8View'); | ||
| ---- | ||
| Andrew X | ||
|
|
||
| query T? | ||
| select * from test where column1 <> arrow_cast('Andrew', 'Utf8View'); | ||
| ---- | ||
| Xiangpeng Xiangpeng | ||
| Raphael R | ||
|
|
||
| statement ok | ||
| drop table test; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for this test to run, we need to add
(Utf8View, Utf8) => Utf8View, see #10985 (comment)