Support DuckDB style struct syntax #11214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
jayzhan211
force-pushed
the
struct-literal
branch
from
955c1d0
to
5a046da
Compare
Signed-off-by: jayzhan211 <[email protected]>
jonahgao
reviewed
Jul 3, 2024
datafusion/sql/src/expr/mod.rs
Outdated
| } | ||
| } | ||
|
|
||
| internal_err!("Expected a simplified result, but none was found") |
There was a problem hiding this comment.
Would it be better to return a not_impl_err error?
User may only use SqlToRel without a SessionState.
alamb
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Thanks @jayzhan211 -- this is so cool!
DataFusion CLI v39.0.0
> select {'foo': 1};
+------------------------------------+
| named_struct(Utf8("foo"),Int64(1)) |
+------------------------------------+
| {foo: 1} |
+------------------------------------+
1 row(s) fetched.
Elapsed 0.015 seconds.
> select {'foo': {'bar': 2}};
+--------------------------------------------------------------+
| named_struct(Utf8("foo"),named_struct(Utf8("bar"),Int64(2))) |
+--------------------------------------------------------------+
| {foo: {bar: 2}} |
+--------------------------------------------------------------+
1 row(s) fetched.
Elapsed 0.002 seconds.I took the liberty of merging up from main to resolve a conflict, and since I had the PR open I also implemented @jonahgao 's suggestion and updated some comments. Hope you don't mind
THank you again
alamb
changed the title
alamb
reviewed
Jul 3, 2024
|
|
||
| user_defined_sql_planners.push(extract_planner); | ||
| } | ||
| let user_defined_sql_planners: Vec<Arc<dyn UserDefinedSQLPlanner>> = vec
9 tasks
comphead
pushed a commit
to comphead/arrow-datafusion
that referenced
this pull request
Jul 8, 2024
* struct literal Signed-off-by: jayzhan211 <[email protected]> * add nested Signed-off-by: jayzhan211 <[email protected]> * fmt Signed-off-by: jayzhan211 <[email protected]> * rm useless comment Signed-off-by: jayzhan211 <[email protected]> * switch to NYI error, derive debug/clone * improve documentation strings * Avoid stack overflow by putting code in a new function --------- Signed-off-by: jayzhan211 <[email protected]> Co-authored-by: Andrew Lamb <[email protected]>
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* struct literal Signed-off-by: jayzhan211 <[email protected]> * add nested Signed-off-by: jayzhan211 <[email protected]> * fmt Signed-off-by: jayzhan211 <[email protected]> * rm useless comment Signed-off-by: jayzhan211 <[email protected]> * switch to NYI error, derive debug/clone * improve documentation strings * Avoid stack overflow by putting code in a new function --------- Signed-off-by: jayzhan211 <[email protected]> Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9820 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?