Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve aggregation documentation for multi-phase aggregation #11695

Closed
wants to merge 2 commits into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 28, 2024

Draft as it builds on #11627

Which issue does this PR close?

Part of #6937

Rationale for this change

As part of reviewing @korowa 's wonderful #11627 to improve multi-phase aggregation I want to document how it works a bit more (so it is easier to add the relevant support for other aggregates)

What changes are included in this PR?

  1. Update docstrings with additional information about multi-phase aggregation

Are these changes tested?

By docs CI

Are there any user-facing changes?

Just docs, no functional changes

@github-actions github-actions bot added documentation Improvements or additions to documentation logical-expr Logical plan and expressions physical-expr Physical Expressions core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jul 28, 2024
@github-actions github-actions bot removed physical-expr Physical Expressions core Core DataFusion crate labels Jul 28, 2024
@alamb
Copy link
Contributor Author

alamb commented Aug 4, 2024

Per korowa#172 (comment)

This was merged into #11627 with b3c033f

@alamb alamb closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants