Enable string view in substrait #11898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Aug 9, 2024
| @@ -153,7 +153,7 @@ fn to_substrait_type(data_type: &DataType, nullable: bool) -> Result<Type> { | |||
| nullability, | |||
| })), | |||
| }), | |||
| DataType::Utf8 => Ok(Type { | |||
| DataType::Utf8 | DataType::Utf8View => Ok(Type { | |||
There was a problem hiding this comment.
I think we need to add some tests here
|
Converting to draft so it is clear this PR isn't waiting on review We should probably file tickets to support |
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11752, a tiny subset of #11862
Rationale for this change
StringView should be considered as String in substrait as well. (I'm not sure why LargeUtf8 is not there, but without Utf8View the test will definitely fail)
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?