Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native stringview support for LEFT #11976

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

Kev1n8
Copy link
Contributor

@Kev1n8 Kev1n8 commented Aug 14, 2024

Which issue does this PR close?

Issue similar to #11917. Instead of RIGHT, this PR adds string view support for LEFT, whose issue has not yet been filed.

Rationale for this change

What changes are included in this PR?

Follow the model in #11955. Add string view support for LEFT and tests.

Are these changes tested?

yes

Are there any user-facing changes?

no

@github-actions github-actions bot added sqllogictest SQL Logic Tests (.slt) functions labels Aug 14, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 -- awesome -- thank you @Kev1n8

It is great to see the code train cranking along

@alamb alamb merged commit b9961c3 into apache:main Aug 14, 2024
24 checks passed
@Kev1n8 Kev1n8 deleted the add-native-stringview-support-for-left branch August 15, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants