benches: add lower benches for stringview #12152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Aug 25, 2024
tshauck
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow up for #11855.
Rationale for this change
I updated the impl of upper and lower to support stringview, but didn't update the benchmarks to include stringview cases. This may be useful in the future if certain optimizations can be added.
It does add a number of new cases, so I can trim them if there's general concern about overall benchmark runtime.
What changes are included in this PR?
Just update the lower benches. I could also update the upper if it's good for completeness, but the lower and upper share 95% of their implementation.
Are these changes tested?
Yes, ran the benchmarks.