doc: Update MSRV policy, shortening to max(4 months, 4 releases) #12402
Conversation
github-actions
bot
added
the
documentation
| @@ -97,9 +97,7 @@ Optional features: | |||
|
|
|||
| ## Rust Version Compatibility Policy | |||
|
|
|||
| DataFusion's Minimum Required Stable Rust Version (MSRV) policy is to support | |||
| each stable Rust version for 6 months after it is | |||
There was a problem hiding this comment.
The previous wording guaranteed support for any rust version for next 6 months.
Given current rust release cadence, shortening the guaranteed support is the main change of this PR. Can we have this reflected in the PR title?
There was a problem hiding this comment.
Good call -- I changed the title to say
doc: Update MSRV policy, shortening to max(4 months, 4 releases)
README.md
Outdated
| [released](https://github.com/rust-lang/rust/blob/master/RELEASES.md). This | ||
| generally translates to support for the most recent 3 to 4 stable Rust versions. | ||
| DataFusion's Minimum Required Stable Rust Version (MSRV) policy is to support stable [4 latest | ||
| Rust versions](https://releases.rs) OR versions within last 4 months, whichever is longer. |
There was a problem hiding this comment.
As written I think they count for 1
How about this for a slightly different wording
DataFusion's Minimum Required Stable Rust Version (MSRV) policy is to support the last 4 minor Rust versions OR the stable minor Rust version as of 4 months , whichever is lower.
For example, given the releases
1.78.0,1.79.0,1.80.0,1.80.1and1.81.0DataFusion will support1.78.0, which is 3 minor versions prior to the most minor recent,1.81.
There was a problem hiding this comment.
Here is a tricky part yes, if you check https://releases.rs for 1.77 you can see there are 2 hotfixes within a month.
But hotfixes are important and we probably should mention it in the policy. That we will support the latest hotfix(if any) of the major minumum supported rust version
There was a problem hiding this comment.
Since we specify only major version, it should pick the latest hotfix automatically, right? we just need to mention it on the separate note
alamb
changed the title
|
Updated the policy, including hotfixes for MSRV, please take a second look |
|
|
||
| For example, given the releases `1.78.0`, `1.79.0`, `1.80.0`, `1.80.1` and `1.81.0` DataFusion will support 1.78.0, which is 3 minor versions prior to the most minor recent `1.81`. | ||
|
|
||
| If a hotfix is released for the minimum supported Rust version (MSRV), the MSRV will be the minor version with all hotfixes, even if it surpasses the four-month window. |
Which issue does this PR close?
Followup on #12398 (comment)
Closes #.
Rationale for this change
Current MSRV policy statement is somewhat confusing on matching between MSRV supported time period and latest Rust versions. The PR is to avoid ambiguity
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?