Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Account for constant equivalence properties in union, tests #12562

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: Account for constant equivalence properties in union, tests #12562

wants to merge 1 commit into from
+707 −402

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Sep 20, 2024 •
edited
Loading

Draft

Which issue does this PR close?

Closes #12446
Closes #12414

Rationale for this change

Fixes a bug: #12446

What changes are included in this PR?

TBD
(I hope to break the comments / test refactor out into separate PRs for easier review)

Are these changes tested?

Yes

Are there any user-facing changes?

Fixed bug

@github-actions github-actions bot added physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt) labels Sep 20, 2024
@alamb alamb mentioned this pull request Sep 20, 2024
Open
alamb
alamb commented Sep 20, 2024
View reviewed changes
datafusion/physical-expr/src/equivalence/properties.rs
let test_cases = vec![
// --------- TEST CASE 1 ----------
(
UnionEquivalenceTest::new(&schema)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted more flexibility with the tests, and I am glad I did this as I hadn't seen the existing tests for constants

@alamb alamb mentioned this pull request Sep 23, 2024
Merged
@github-actions github-actions bot added the core Core DataFusion crate label Sep 23, 2024
@alamb alamb mentioned this pull request Sep 23, 2024
Merged
@alamb alamb mentioned this pull request Sep 23, 2024
Merged
@alamb alamb force-pushed the alamb/union_sorting branch 2 times, most recently from b72a1d1 to 48bebcb Compare September 25, 2024 23:05
@github-actions github-actions bot removed the core Core DataFusion crate label Sep 25, 2024
@alamb alamb force-pushed the alamb/union_sorting branch 2 times, most recently from 6333c3f to 23cfc58 Compare September 30, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SanityChecker rejects certain valid UNION plans
1 participant
@alamb