Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate LexOrderingRef and LexRequirementRef #13205

Closed
wants to merge 18 commits into from
Closed

Deprecate LexOrderingRef and LexRequirementRef #13205

wants to merge 18 commits into from
+1,360 −1,080

Commits on Oct 28, 2024

  1. Conversion types for LexOrdering and LexOrderingRef to structs.

    nglime committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    4122518 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into feature/lex-orderin… 

    …g-request-struct
    nglime committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ff430c1 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Format and fix type errors. Adjusted expected output when using `LexO… 

    …rdering`.
    nglime committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    bf53894 View commit details
    Browse the repository at this point in the history

  2. Updated usage of FromIterator and removed empty() in favor of `de… 

    …fault()`.
    nglime committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8d3af8e View commit details
    Browse the repository at this point in the history

  3. Adjusted chained map and flatten calls to flat_map, and swapped… 

    … `unwrap_or` to `unwrap_or_default`.
    nglime committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    0ce3e17 View commit details
    Browse the repository at this point in the history

  4. Adjusted slt files to include a space after commas, when relating to … 

    …LexOrdering and LexOrderingRef.
    nglime committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ac64879 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feature/lex-ordering-request-struct

    @ngli-me
    ngli-me authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2825c1d View commit details
    Browse the repository at this point in the history

  6. Removed unnecessary path prefixes in sort_expr.

    nglime committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b62a988 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Merge remote-tracking branch 'upstream/main' into feature/lex-orderin… 

    …g-request-struct
    nglime committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6fdd4ae View commit details
    Browse the repository at this point in the history

  2. Fixed tpch slt files.

    nglime committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5c78e93 View commit details
    Browse the repository at this point in the history

  3. Removed LexOrderingRef struct.

    nglime committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2e91bc5 View commit details
    Browse the repository at this point in the history

  4. Removed dereferences to LexOrderingRef left over from the struct re… 

    …moval.
    nglime committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    682bc21 View commit details
    Browse the repository at this point in the history

  5. Removed remaining usage of the raw LexOrderingRef type.

    nglime committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9cd6f14 View commit details
    Browse the repository at this point in the history

  6. Formatting.

    nglime committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    406e625 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Berkay Şahin <[email protected]>
    @ngli-me @berkaysynnada
    ngli-me and berkaysynnada authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0e69ccc View commit details
    Browse the repository at this point in the history

  2. Deprecate LexOrderingRef and LexRequirementRef

    @alamb
    alamb committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    da5fc7c View commit details
    Browse the repository at this point in the history

  3. more

    @alamb
    alamb committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5f41292 View commit details
    Browse the repository at this point in the history

  4. more

    @alamb
    alamb committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1d0ba80 View commit details
    Browse the repository at this point in the history