Expand LIKE simplification #13260
Draft
Expand LIKE simplification #13260
+299
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`expr LIKE '%'` was previously simplified to `true`, but the expression returns `NULL` when `expr` is null. The conversion was conditional on `!is_null(expr)` which means "is not always true, i.e. is not a null literal". This commit adds correct simplification logic. It additionally expands the rule coverage to include string view (Utf8View) and large string (LargeUtf8). This allows writing shared test cases even despite `utf8_view LIKE '%'` returning incorrect results at execution time (tracked by apache#12637). I.e. the simplification masks the bug for cases where pattern is statically known.
github-actions
bot
added
optimizer
- cover expression known not to be null - cover NULL pattern - cover repeated '%%' in pattern
findepi
force-pushed
the
findepi/expand-like-simplification-e96eca
branch
from
c6285bf
to
be26107
Compare
|
currently depends on #13259 |
|
seemed easy enough, done. |
findepi
force-pushed
the
findepi/expand-like-simplification-e96eca
branch
from
88d6df1
to
6c57af7
Compare
|
I’m happy with my changes being included in this PR :) |
|
draft - to be rebased after #13259 lands still ready to review |
goldmedal
reviewed
Nov 5, 2024
#13259 has been merged. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXPR LIKE 'constant'toexpr = 'constant'#13061 to resolve conflicts