Feature: Monotonic Sets #14271
Open
Feature: Monotonic Sets #14271
+670
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # datafusion/core/src/physical_optimizer/enforce_sorting.rs # datafusion/core/src/physical_optimizer/test_utils.rs
# Conflicts: # datafusion/core/src/physical_optimizer/enforce_sorting.rs # datafusion/physical-optimizer/src/test_utils.rs
separate stubs and count_udafs
change monotonicity to return an Enum rather than Option<bool> fix indices re-add monotonicity tests
# Conflicts: # datafusion/core/tests/physical_optimizer/enforce_sorting.rs
github-actions
bot
added
logical-expr
mertak-synnada
commented
Jan 24, 2025
| @@ -4963,6 +4963,9 @@ false | |||
| true | |||
| NULL | |||
|
|
|||
| statement ok | |||
There was a problem hiding this comment.
These are related with #14231
2010YOUY01
reviewed
Jan 25, 2025
| /// function is monotonically increasing if its value increases as its argument grows | ||
| /// (as a set). Formally, `f` is a monotonically increasing set function if `f(S) >= f(T)` | ||
| /// whenever `S` is a superset of `T`. | ||
| fn monotonicity(&self, _data_type: &DataType) -> AggregateExprMonotonicity { |
There was a problem hiding this comment.
I recommend adding a note at the beginning of the comment: This is used for a specific (is it BoundedWindowAggExec? )optimization and can be skipped by using the default implementation.
This interface seems quite difficult to understand for a general user who only wants to add a simple UDAF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This PR creates a definition of set-monotonicity for Aggregate expressions. Some aggregation functions create ordered results by definition (such as count, min, max). With this PR, we're adding this information to the output ordering and be able to remove some SortExecs while optimizing
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?