Add regexp_extract func #14282
Open
Add regexp_extract func #14282
+364
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Omega359
reviewed
Jan 25, 2025
Omega359
reviewed
Jan 25, 2025
Omega359
reviewed
Jan 25, 2025
| } | ||
|
|
||
| fn regexp_extract<T: OffsetSizeTrait>(args: &[ArrayRef]) -> Result<ArrayRef> { | ||
| let target = as_generic_string_array::<T>(&args[0])?; |
There was a problem hiding this comment.
I'd have to check but I don't think this would work with DataType::Utf8View. Could some sql tests be added that cover all the possible input types?
There was a problem hiding this comment.
I've added one more sql test and according to its result it works
Omega359
reviewed
Jan 25, 2025
|
Thanks for your contribution! I've left some comments for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #14280.
Rationale for this change
Adding more functions
What changes are included in this PR?
The implementation of regexp_extract based on Spark regexp_extract
Are these changes tested?
Yes
Are there any user-facing changes?
No