Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqllogictest: use the same normalization for all tests #5013

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

melgenek
Copy link
Contributor

Which issue does this PR close?

Closes #5010.

Rationale for this change

This change simplifies the sqllogictest results normalization logic. It is now the same for all test files.

What changes are included in this PR?

  • the sqllogictest tests are updated to use the same normalization all the time
  • some test results are adjusted to match the new normalization logic

Are these changes tested?

There are Github Actions for both Datafusion and Postgres sqllogictest runners.

Are there any user-facing changes?

No.

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jan 21, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- thank you @melgenek

cc @xudong963

@@ -22,19 +22,19 @@
query R
SELECT avg(c12) FROM aggregate_test_100
----
0.5089725099127211
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit 8dc4c96 into apache:master Jan 23, 2023
@alamb
Copy link
Contributor

alamb commented Jan 23, 2023

Thanks again @melgenek -- these improvements are really nice

@ursabot
Copy link

ursabot commented Jan 23, 2023

Benchmark runs are scheduled for baseline = 407caad and contender = 8dc4c96. 8dc4c96 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@melgenek melgenek deleted the 5010-unified-normalization branch January 25, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sqllogictest] Consolidate normalization code for the postgres and non-postgres paths
3 participants