Minor: Improve aggregate test coverage more #6952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
commented
Jul 13, 2023
| statement ok | ||
| CREATE TABLE empty (column1 bigint, column2 int); | ||
|
|
||
| # no group by column |
There was a problem hiding this comment.
The null tests didn't originally have coverage for the no group by case so I added that and consolidated some tests
alamb
commented
Jul 13, 2023
| (33, 11, null, 'B'), | ||
| (9, 12, null, 'A'); | ||
|
|
||
| # query_bit_and, query_bit_or, query_bit_xor |
There was a problem hiding this comment.
These also didn't have coverage for GROUP BY , so I consolidated the tests and added grouping coverage
| SELECT | ||
| c1, | ||
| SUM(c2) FILTER (WHERE c2 >= 20), | ||
| SUM(c2) FILTER (WHERE c2 < 1) -- no rows pass filter, so the output should be NULL |
There was a problem hiding this comment.
added some additional coverage with filtering
|
|
||
| # query_group_by_with_multiple_filters | ||
| query IIR rowsort | ||
| SELECT c1, SUM(c2) FILTER (WHERE c2 >= 20) AS sum_c2, AVG(c3) FILTER (WHERE c3 <= 70) AS avg_c3 FROM test_table GROUP BY c1 |
There was a problem hiding this comment.
this was just some whitespace OCD
This was referenced Jul 13, 2023
|
And this found a bug #6955 🎉 |
alamb
force-pushed
the
alamb/more_aggregate_tests
branch
from
94e8212
to
5f01044
Compare
|
I think this is important coverage to add so I am merging it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #6939
Related to #6889
Rationale for this change
I almost merged code that had incorrect aggregate null handling and the tests didn't catch it
This is my attempt to improve coverage
What changes are included in this PR?
Add some more tests of aggregates (several types were missing coverage with
GROUP BY). I'll comment inlineAre these changes tested?
Are there any user-facing changes?