Minor: remove duplication in Min/Max accumulator #6960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jul 13, 2023
| }, | ||
| ) | ||
| // Initialize each accumulator to $NATIVE::MIN | ||
| .with_starting_value($NATIVE::MIN), |
There was a problem hiding this comment.
Min/max need to start with some value other than zero
|
FYI @Dandandan |
Dandandan
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
related to
Rationale for this change
While working on #6957 to provide a default starting value, I realized this could be used to consolidate the Min/Max accumulator implementation as well to avoid duplication
What changes are included in this PR?
Change min/max to use the standard
PrimitiveGroupsAccumulatorrather than implementing itselfAre these changes tested?
Existing coverage
Are there any user-facing changes?
No, this is just less code