refactor: make all udf function impls public #9903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
alamb
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Makes sense to me -- thank you @universalmind303
I wonder if you want to try and add some sort of test to ensure these are all pub somehow? If not, I predict that as we port over additional functions some will get missed
jayzhan211
reviewed
Apr 2, 2024
| @@ -54,11 +54,17 @@ make_udf_function!(ArrayHasAny, | |||
| ); | |||
|
|
|||
| #[derive(Debug)] | |||
| pub(super) struct ArrayHas { | |||
There was a problem hiding this comment.
It seems that all the arrays function are public, do you plan to public the rest of them too?
There was a problem hiding this comment.
Yes, this should include all of functions from functions and functions-array crates at the time of authoring.
|
Thanks @universalmind303. BTW @viirya is discussing adding a way to instantiate only some of the UDFs here #9892 |
|
I merged this branch up locally to main and verified clippy and tests passed. 🚀 |
alamb
pushed a commit
to alamb/datafusion
that referenced
this pull request
Apr 16, 2024
* refactor: make all udf function impls public * clippy
alamb
added a commit
that referenced
this pull request
Apr 17, 2024
* refactor: make all udf function impls public * clippy Co-authored-by: universalmind303 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9900
Rationale for this change
What changes are included in this PR?
this just makes all of the structs implementing
ScalarUDFImplpublicly accessibleAre these changes tested?
Are there any user-facing changes?